Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] Fix subspace broadcast issue #183

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

PinetreePantry
Copy link
Collaborator

@PinetreePantry PinetreePantry commented Aug 13, 2024

Description

Subspace broadcasting did not handle many cases that require broadcasting. This has been causing subtle bugs in pyvene calls with subspaces

Testing Done

Checklist:

  • My PR title strictly follows the format: [Your Priority] Your Title
  • I have attached the testing log above
  • I provide enough comments to my code
  • I have changed documentations
  • I have added tests for my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant