Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: add PPC support, unbreak build on Darwin #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barracuda156
Copy link

-march= is unsupported on PPC, but it is used in a fallback, therefore breaking the build on macOS PPC (and likely Big Endian FreeBSD, Linux etc).
I have used -DHPTT_ARCH_IBM for Apple here, since the code appears Altivec-compatible and builds fine. However once/if insns from ISA newer than 2.03 are added, non-VSX code should be retained separately for cases where those are unsupported, and then -DHPTT_ARCH_PPC will be needed.

P. S. I suspect that a separate case may be needed for Apple Clang on Intel, since it does not support OpenMP (at least most of its versions). But keeping this PR to PPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant