Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favpro hotfix #782

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Favpro hotfix #782

merged 7 commits into from
Jan 12, 2024

Conversation

zbeekman
Copy link
Collaborator

@zbeekman zbeekman commented Jan 12, 2024

coverage on master
Codecov branch

Summary of changes

  • FIx CI on *nix
    • upgraded to slightly newer gcc (11)
  • Added windows CI
  • Build system fixes for windows
  • Fixed a minor shellcheck issue

Rationale for changes

support windows builds more fully/natively

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

Copy link
Member

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson merged commit df27aa6 into main Jan 12, 2024
4 checks passed
@rouson rouson deleted the favpro-hotfix branch January 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants