Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/DOC: Add a test for vanhove and fix the documented example. #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielballan
Copy link
Member

The problem reported in #394 is still a mystery to me, but it did highlight
that the vanhove function has no test coverage. Here is a simple smoke
test. It passes for me locally, in a fresh environment with the latest version
of all the required dependencies (obtained via pip):

$ pip list
cycler (0.10.0)
kiwisolver (1.0.1)
matplotlib (2.2.3)
nose (1.3.7)
numpy (1.15.0)
pandas (0.23.4)
pip (9.0.1)
pkg-resources (0.0.0)
pyparsing (2.2.0)
python-dateutil (2.7.3)
pytz (2018.5)
PyYAML (3.13)
scipy (1.1.0)
setuptools (39.0.1)
six (1.11.0)
trackpy (0.4.1+26.g964a3ae.dirty, /home/dallan/Repos/bnl/trackpy)
wheel (0.31.1)

The documented example was missing a required argument (lagtime). I fixed
that.

The documented example was missing a required argument.
@caspervdw
Copy link
Member

@danielballan We need #517 to assess the error in the CI. Btw, good to do some work at trackpy again. We either should try keeping it up or find other contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants