Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image tag to alpine/curl #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amitsagtani97
Copy link

Description

While using the helm template command to download and ship step-certificates chart in an air-gapped environment, getting this error -

Container alpine/curl without a tag found or pin found. Aborting! Fix this chart. not compatible with offline. Components need explicit tags for that

In the tests, we are currently using alpine/curl image without a tag, that is creating the issue. This pr fixes this by adding a tag to alpine/curl image.

@amitsagtani97 amitsagtani97 requested a review from a team as a code owner September 17, 2024 10:37
@CLAassistant
Copy link

CLAassistant commented Sep 17, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Sep 17, 2024
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the use of :latest instead of an explicit version would work for your use case?

@@ -10,7 +10,7 @@ metadata:
spec:
containers:
- name: curl
image: alpine/curl
image: alpine/curl:8.10.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: alpine/curl:8.10.0
image: alpine/curl:latest

@jschumacher-wire
Copy link

Would the use of :latest instead of an explicit version would work for your use case?

Yes, that would work as well.

Would the use of :latest instead of an explicit version would work for your use case?

Hi @maraino, yes that should work as well. I created a suggestion from @amitsagtani97's PR, unfortunately he's OOO for a few days/weeks. Please go ahead and merge, if you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants