wire SkipValidation further into SCEP provisioner #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
github-actions
bot
added
the
needs triage
hslatman
reviewed
Sep 17, 2024
| Intermediates: a.intermediateX509Certs, | ||
| Roots: a.rootX509Certs, | ||
| Intermediates: a.intermediateX509Certs, | ||
| SkipValidation: a.config.SkipValidation, |
There was a problem hiding this comment.
Can you create a new property called SkipSCEPValidation in the config.Config instead, and pass that here?
Comment on lines
+29
to
+31
| // SkipValidation is used to skip the validation of the options, when implementing custom | ||
| // integrations | ||
| SkipValidation bool |
There was a problem hiding this comment.
This can remain SkipValidation, but update the comment
Suggested change
| // SkipValidation is used to skip the validation of the options, when implementing custom | |
| // integrations | |
| SkipValidation bool | |
| // SkipValidation is used to skip the validation of the SCEP options. | |
| SkipValidation bool |
Comment on lines
+40
to
44
| if o.SkipValidation { | ||
| return nil | ||
| } | ||
| switch { | ||
| case len(o.Intermediates) == 0: |
There was a problem hiding this comment.
Suggested change
| if o.SkipValidation { | |
| return nil | |
| } | |
| switch { | |
| case len(o.Intermediates) == 0: | |
| switch { | |
| case o.SkipValidation: | |
| return nil | |
| case len(o.Intermediates) == 0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
pass SkipValidation further into the SCEP provisioner
Pain or issue this feature alleviates:
When writing custom integrations, some of the validations don't apply, which unintentionally prevents the provisioner from starting up.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
No additional docs
In what environments or workflows is this feature supported?
Primarily for custom integrations which create their own provisioner/authority objects
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!