Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS auth method for Vault RA mode #1976

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

leonweecs
Copy link
Contributor

@leonweecs leonweecs commented Aug 28, 2024

Implements #1946

Name of feature:

Add AWS auth method for Vault RA mode.

The available authOptions maps directly to the Vault AWS auth package.

Pain or issue this feature alleviates:

Please refer to #1946.

Why is this important to the project (if not answered above):

N/A

Is there documentation on how to use this feature? If so, where?

Yes, a separate PR will be raised for the docs repo.

smallstep/docs#346

In what environments or workflows is this feature supported?

  • AWS
  • Vault RA mode

In what environments or workflows is this feature explicitly NOT supported (if any)?

N/A

Supporting links/other PRs/issues:

💔Thank you!

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Aug 28, 2024
leonweecs added a commit to leonweecs/smallstep-docs that referenced this pull request Aug 28, 2024
cas/vaultcas/auth/aws/aws.go Outdated Show resolved Hide resolved
cas/vaultcas/auth/aws/aws.go Outdated Show resolved Hide resolved
cas/vaultcas/auth/aws/aws_test.go Outdated Show resolved Hide resolved
@hslatman
Copy link
Member

hslatman commented Sep 11, 2024

Don't forget to fix the conflicts by rebasing or some other way

The action failure looks like a flake.

This commit adds the AWS auth method for Vault RA mode following similar
pattern in the existing approle and kubernetes methods.

This auth method supports both iam and ec2 auth type, see
https://developer.hashicorp.com/vault/docs/auth/aws for more info.

Implements smallstep#1946
@hslatman hslatman merged commit c118a2a into smallstep:master Sep 12, 2024
13 checks passed
@hslatman hslatman added this to the v0.27.3 milestone Sep 12, 2024
@hslatman hslatman linked an issue Sep 12, 2024 that may be closed by this pull request
@hslatman
Copy link
Member

Thank you, @leonweecs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault RA mode supports AWS auth method
2 participants