login form added #43
login form added #43
Conversation
|
Nice work! Can you make few changes, though:
|
|
I haven't seen the diffs till now, but it really looks good already ! 😄 |
|
Can this be merged ? |
|
Damn this looks nice. 👍 |
| @@ -1,34 +1,41 @@ | |||
| @import url(http://fonts.googleapis.com/css?family=Source+Sans+Pro:200,300); | |||
There was a problem hiding this comment.
It gives the following warning The page at 'https://chat.sdslabs.co/' was loaded over HTTPS, but requested an insecure stylesheet 'http://fonts.googleapis.com/css?family=Source+Sans+Pro:200,300'. This content should also be served over HTTPS.
There was a problem hiding this comment.
changing it to https would do
There was a problem hiding this comment.
A better fix would be to use //fonts instead of http://fonts or https://fonts.
There was a problem hiding this comment.
Always use https: https://www.paulirish.com/2010/the-protocol-relative-url/
There was a problem hiding this comment.
My bad, This article makes a lot of sense.
|
Another issue is that, if you ban a nick from slack. It still gets accepted on the login screen, but only when the user tries to send a message with the banned nick. He gets that old prompt box asking for another username. I have mentioned it here #44 |
|
@csoni111 It would be nice if you could file a separate issue for the above bug. :) |
|
Hi people, Warm regards, On 14-Oct-2016 1:05 AM, "Utkarsh Gupta" [email protected] wrote:
|
|
Never mind, I just unsubscribed myself. On 14-Oct-2016 1:07 AM, "Rishi Devgan" [email protected] wrote:
|
Added a login screen in accordance to issue #10 . a live preview is available on https://slack12345.herokuapp.com (this is my instance of jinora for testing purpose)