Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipLibCheck so we stop checking node_modules package definitions #3707

Closed
wants to merge 1 commit into from

Conversation

wwahammy
Copy link
Contributor

skipLibCheck skips checking type declaration files. This should fix typescript type checking in the build

@ocdtrekkie
Copy link
Collaborator

How does this differ from #3668?

@ocdtrekkie ocdtrekkie added the sandstorm-dev Issues hacking on Sandstorm label Jan 14, 2024
@wwahammy
Copy link
Contributor Author

How does this differ from #3668?

strictNullChecks is a safety feature; generally you'd want to keep that if you can because it reduces the risk of various errors.

As I've always understood it, all of the strictness rules are important but one issue is how they apply to any typings you have downloaded. After all, you might not be able to trust that every dependency followed the same compilation rules. The only situation where you could if you had a pretty strong control over all of your dependencies. Generally though, on most projects you don't; you're getting dependencies from all over. skipLibCheck allows you to opt libraries out of the these strictness rules while making sure all of your code meets that standard. Generally, that's how projects I've worked on are configured.

@ocdtrekkie
Copy link
Collaborator

Do you want to sync this branch so we can test it with the other fixes included?

@wwahammy
Copy link
Contributor Author

@ocdtrekkie ts-check passes now 🥳

@ocdtrekkie
Copy link
Collaborator

Closing this one, as I merged 3708 into the dev branch, which includes this commit.

@ocdtrekkie ocdtrekkie closed this Feb 5, 2024
@wwahammy wwahammy deleted the correct-the-lib-check branch February 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sandstorm-dev Issues hacking on Sandstorm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants