Creates a new configuration file in rsyslog.d directory with any content. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n new config file - /etc/rsyslog.d/app.conf directory in the /etc/rsyslog.d directory
fpytloun
reviewed
Dec 10, 2019
|
|
||
| pillars: | ||
| rsyslog: | ||
| rsyslogd: |
There was a problem hiding this comment.
I would consider renaming this key to custom or something to be able to determine it's custom config, something extra and not native feature of this formula..
In general we don't like these things much - states should have supported set of features and should not accept entering direct service configuration from model (pillar) as it cannot quarantee it will behave as user wants. But there are exceptions in some formulas, especially those that can't cover all possible use-cases so I am fine with this change for rsyslog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If necessary, creates a new configuration file with any content that your
written in new config file - /etc/rsyslog.d/app.conf directory in the /etc/rsyslog.d directory