Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release-distribution): update static-router to node 20 #539

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Aug 28, 2024

Related to #376

Plan:

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_cloudfront_distribution.static will be updated in-place
  ~ resource "aws_cloudfront_distribution" "static" {
        id                             = "E30AO2GXMDY230"
        tags                           = {}
        # (20 unchanged attributes hidden)

      ~ default_cache_behavior {
            # (11 unchanged attributes hidden)

          - lambda_function_association {
              - event_type   = "origin-request" -> null
              - include_body = false -> null
              - lambda_arn   = "arn:aws:lambda:us-east-1:890664054962:function:dev-static-rust-lang-org--static-router:9" -> null
            }
          + lambda_function_association {
              + event_type   = "origin-request"
              + include_body = false
              + lambda_arn   = (known after apply)
            }

            # (1 unchanged block hidden)
        }

        # (5 unchanged blocks hidden)
    }

  # fastly_service_vcl.static will be updated in-place
  ~ resource "fastly_service_vcl" "static" {
      ~ active_version     = 27 -> (known after apply)
      ~ cloned_version     = 27 -> (known after apply)
        id                 = "5qaYFyyiorVua6uCZg7It0"
        name               = "dev-static.rust-lang.org"
        # (8 unchanged attributes hidden)

      - logging_datadog {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }
      + logging_datadog {
          # At least one attribute in this block is (or was) sensitive,
          # so its contents will not be displayed.
        }

        # (11 unchanged blocks hidden)
    }

  # module.lambda_static.aws_lambda_function.lambda will be updated in-place
  ~ resource "aws_lambda_function" "lambda" {
        id                             = "dev-static-rust-lang-org--static-router"
      ~ qualified_arn                  = "arn:aws:lambda:us-east-1:890664054962:function:dev-static-rust-lang-org--static-router:9" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-east-1:lambda:path/2015-03-31/functions/arn:aws:lambda:us-east-1:890664054962:function:dev-static-rust-lang-org--static-router:9/invocations" -> (known after apply)
      ~ runtime                        = "nodejs16.x" -> "nodejs20.x"
        tags                           = {}
      ~ version                        = "9" -> (known after apply)
        # (19 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

This looks ok to me!

Shall I test it on dev?

@MarcoIeni MarcoIeni force-pushed the chore-release-distribution-update-static-router-lambda-runtime-to-node-20 branch from f571465 to 42f3ba6 Compare August 28, 2024 13:09
@MarcoIeni MarcoIeni marked this pull request as ready for review August 28, 2024 13:14
@MarcoIeni
Copy link
Member Author

tested in dev https://dev-static.rust-lang.org/dist/2023-11-13/index.html and https://dev-static.rust-lang.org/rustup.sh

they are working. So I'm merging and deploying to prod

@MarcoIeni MarcoIeni merged commit 1b5840f into master Sep 20, 2024
3 checks passed
@MarcoIeni MarcoIeni deleted the chore-release-distribution-update-static-router-lambda-runtime-to-node-20 branch September 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant