N52: egui_ratatui #1526
Merged
N52: egui_ratatui #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
Vrixyz
reviewed
Jun 7, 2024
|
Made an editorial pass. I'll merge it after the CI passes, but feel free to comment if you don't like something and I'll fix it in a follow-up PR :) Feel free to also link your game once it's public! PS: is your name a Gödel, Escher, Bach reference? |
janhohenheim
approved these changes
Jun 29, 2024
|
@janhohenheim Thank you for the editorial pass, I think you did a great job. My name is not a Gödel, Escher, Bach reference, although that is a fantastic book. My name is based on my fascination with these 3 metals, due to their conductivity, shininess, and many other interesting chemical properties. I think they are super cool. Happy programming and publishing ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1523