-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uses of "dropdown" with respective ViewComponent #5907
Open
iamronakgupta
wants to merge
21
commits into
rubyforgood:main
Choose a base branch
from
iamronakgupta:5845-replace-dropdown-to-viewcomponent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replace uses of "dropdown" with respective ViewComponent #5907
iamronakgupta
wants to merge
21
commits into
rubyforgood:main
from
iamronakgupta:5845-replace-dropdown-to-viewcomponent
Commits on Jun 29, 2024
-
moved three dots icon from component to html.erb
Only one dropdown button were using three dots icons hence it is better to put it on block of component from html.erb.
Configuration menu - View commit details
-
Copy full SHA for f6cba70 - Browse repository at this point
Copy the full SHA f6cba70View commit details -
updated: button css classes added to dropdown as variable
display: flex and align-items: center added to style to align items of button horizontally. button_class variable added to dropdown component to dynamically change css properties of button like background color
Configuration menu - View commit details
-
Copy full SHA for 5db3caf - Browse repository at this point
Copy the full SHA 5db3cafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fef6a2 - Browse repository at this point
Copy the full SHA 9fef6a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 130bbc8 - Browse repository at this point
Copy the full SHA 130bbc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for da11c46 - Browse repository at this point
Copy the full SHA da11c46View commit details -
Configuration menu - View commit details
-
Copy full SHA for f488c1a - Browse repository at this point
Copy the full SHA f488c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b85dae - Browse repository at this point
Copy the full SHA 4b85daeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23ba785 - Browse repository at this point
Copy the full SHA 23ba785View commit details -
Configuration menu - View commit details
-
Copy full SHA for 957dc23 - Browse repository at this point
Copy the full SHA 957dc23View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9c5124 - Browse repository at this point
Copy the full SHA c9c5124View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 937f1c7 - Browse repository at this point
Copy the full SHA 937f1c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d5736f - Browse repository at this point
Copy the full SHA 4d5736fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0ef511 - Browse repository at this point
Copy the full SHA d0ef511View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5792d22 - Browse repository at this point
Copy the full SHA 5792d22View commit details
Commits on Jul 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd439b3 - Browse repository at this point
Copy the full SHA bd439b3View commit details
Commits on Jul 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9511292 - Browse repository at this point
Copy the full SHA 9511292View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68aff5a - Browse repository at this point
Copy the full SHA 68aff5aView commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8fb7d62 - Browse repository at this point
Copy the full SHA 8fb7d62View commit details
Commits on Jul 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c0045a8 - Browse repository at this point
Copy the full SHA c0045a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ef8ed2 - Browse repository at this point
Copy the full SHA 1ef8ed2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fce7d90 - Browse repository at this point
Copy the full SHA fce7d90View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.