Add Rename Classes UQL Operation #656
Conversation
NickHerrig
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
|
@PawelPeczek-Roboflow let me know if you have any feedback any here from our convo today. |
There was a problem hiding this comment.
There is one issue with potential collapse of class id:
original detections have 1-1 relationship between class name and class id, after mapping this is not guaranteed.
Additional difficulty is also keeping original class.
Maintaining classes ids may be important - for instance to have visualisation that works consistently (look how this is implemented in supervision)
Proposed solution:
- enforce full mapping - if not given raise operation error
- when classes collapse - keep lower class id
if for some reason we wish to let non-strict class mappings, I suggest adding operation parameter (strict: bool with default True), such that people take risk by willingly declaring so.
| @@ -28,6 +28,11 @@ def red_image() -> np.ndarray: | |||
| return cv2.imread(os.path.join(ASSETS_DIR, "red_image.png")) | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="function") | |||
| def fruit_image() -> np.ndarray: | |||
| return cv2.imread(os.path.join(ASSETS_DIR, "multi-fruit.jpg")) | |||
There was a problem hiding this comment.
please report image credits
| @@ -0,0 +1,124 @@ | |||
| import numpy as np | |||
There was a problem hiding this comment.
great tests coverage
Description
This PR adds UQL operation to handle renaming of classes given a
class_map.Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?