Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1306 - Update address bar on clicking a link #1307

Merged

Conversation

Asatyam
Copy link
Contributor

@Asatyam Asatyam commented Sep 18, 2024

✨ Pull Request

📓 Referenced Issue

Fixes #1306

ℹ️ About the PR

Add the event listener for handling the change in address bar if the click happens inside the browser without reloading or going to a new page

🖼️ Testing Scenarios / Screenshots

Screen.Recording.2024-09-18.at.5.08.34.PM.mov

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

@violetadev violetadev merged commit 508fd73 into responsively-org:main Sep 18, 2024
4 checks passed
@violetadev
Copy link
Contributor

ty for contributing!

@all-contributors Please add @Asatyam for code.

Copy link
Contributor

@violetadev

I've put up a pull request to add @Asatyam! 🎉

@1chooo
Copy link

1chooo commented Sep 18, 2024

That’s really nice! Thanks @Asatyam, @violetadev

@Asatyam Asatyam deleted the fix/update-address-bar-1306 branch September 18, 2024 12:31
Copy link

@1chooo 1chooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] URL Not Updating When Navigating Between Pages
4 participants