Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update !context bot command formatting and add descriptive (hyper-)links #306

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Update !context bot command formatting and add descriptive (hyper-)links #306

merged 4 commits into from
Aug 10, 2023

Conversation

ManonLef
Copy link
Contributor

@ManonLef ManonLef commented Aug 10, 2023

This PR

  • edits formatting of the !context embed contents to look better on mobile
  • changes the links into a list of links in descriptive format

(edit: apologies for the former PR edits/commits to show up, hope you can squash them away :))

Current output on app/site and mobile respectively

Screenshot 2023-08-10 at 22 09 39
IMG_5049

This PR Output on app/site and mobile respectively

Screenshot 2023-08-10 at 22 09 48
IMG_5050

@ghost
Copy link

ghost commented Aug 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@what-the-diff
Copy link

what-the-diff bot commented Aug 10, 2023

PR Summary

  • Update on src/features/commands.ts
    This change enhances the readability of the code and provides additional educational resources. The text has been reformatted for improved coherence, while references to articles explaining the differences between Redux and Context have been added.

  • Modifications to src/components/Button.tsx
    To increase the versatility of our Button component, a new variant named 'danger' has been added. This variant can be used to signify actions in the user interface that could lead to destructive results, which enhances our ability to guide user behaviors.

  • Adjustment to src/styles/global.scss
    Aesthetic adjustments have been made to our global styles. A new color variable denominated as $color-danger is available for use. Also, we've specified the look of our newly created 'danger' button variant, marking it with a distinct background color and white text to signify potential high-risk actions to our users.

Copy link
Member

@vcarl vcarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! Pesky multiline strings 😁

@vcarl vcarl merged commit e688d73 into reactiflux:main Aug 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants