Pagination and logging fixes

scheduler.py

@@ -1,4 +1,5 @@
 import logging
+import traceback
 
 from apscheduler.schedulers.blocking import BlockingScheduler
 from raven.base import Client as RavenClient
@@ -41,7 +42,7 @@ def destalinate_job():
         except Exception as e:  # pylint: disable=W0703
             raven_client.captureException()
             if not get_config().sentry_dsn:
-                raise e
+                raise traceback.format_exc()
     logging.info("END: destalinate_job")
 
 

slacker.py

@@ -206,20 +206,60 @@ def get_all_channel_objects(self, exclude_archived=True):
         return all channels
         if exclude_archived (default: True), only shows non-archived channels
         """
+        next_page = True
+        channels = []
 
         url_template = self.url + "channels.list?exclude_archived={}&token={}"
         if exclude_archived:
             exclude_archived = 1
         else:
             exclude_archived = 0
         url = url_template.format(exclude_archived, self.token)
-        payload = self.get_with_retry_to_json(url)
-        assert 'channels' in payload
-        return payload['channels']
+        orig_url = url
+
+        while next_page is True:
+            response = self.get_with_retry_to_json(url)
+            channels += response['channels']
+
+            if 'response_metadata' in response:
+                if 'next_cursor' in response['response_metadata']:
+                    if response['response_metadata']['next_cursor']:
+                        cursor = response['response_metadata']['next_cursor']
+
+            if cursor:
+                url = orig_url + "&cursor=" + response['response_metadata']['next_cursor']
+            else:
+                next_page = False
+
+            cursor = None
+
+        return channels
 
     def get_all_user_objects(self):
+        next_page = True
+        members = []
+
         url = self.url + "users.list?token=" + self.token
-        return self.get_with_retry_to_json(url)['members']
+        orig_url = url
+
+        while next_page is True:
+            response = self.get_with_retry_to_json(url)
+            members += response['members']
+
+            if 'response_metadata' in response:
+                if 'next_cursor' in response['response_metadata']:
+                    if response['response_metadata']['next_cursor']:
+                        cursor = response['response_metadata']['next_cursor']
+
+            if cursor:
+                url = orig_url + "&cursor=" \
+                    + response['response_metadata']['next_cursor']
+            else:
+                next_page = False
+
+            cursor = None
+
+        return members
 
     def archive(self, channel_name):
         url_template = self.url + "channels.archive?token={}&channel={}"

utils/slack_logging.py

@@ -20,7 +20,7 @@ def __init__(self, slackbot, level):
 
     def emit(self, record):
         """Do whatever it takes to actually log the specified logging record."""
-        self.slackbot.say(self.config.log_channel, record.getMessage())
+        self.slackbot.say(get_config().log_channel, record.getMessage())
 
 
 def set_up_slack_logger(slackbot=None):
@@ -35,7 +35,7 @@ def set_up_slack_logger(slackbot=None):
     """
     logger = logging.getLogger()
 
-    if logger.handlers:
+    if len(logger.handlers) > 1:
         # We've likely already ran through the rest of this method:
         return