Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setup.cfg config settings to pyproject.toml #919

Merged

Conversation

david-yz-liu
Copy link
Contributor

@david-yz-liu david-yz-liu commented Jun 24, 2023

Motivation and Context

The Python packaging ecosystem is standardizing on pyproject.toml (PEP 621), and this way we can consolidate all of the project settings in one place. Also Dependabot will scan for dependencies in pyproject.toml but not setup.cfg.

Your Changes

Description: Moved setup.cfg settings into pyproject.toml. Moved nodes/ and sample_usage/ folders into examples to make the package conform to the flat layout.

Type of change (select all that apply):

  • Other (please specify): Package configuration and file organization

Testing

Ensured that the package can still be installed with the updated settings.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5365525050

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.399%

Totals Coverage Status
Change from base Build 5365146570: 0.02%
Covered Lines: 1771
Relevant Lines: 1981

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 8bf8470 into pyta-uoft:master Jun 24, 2023
5 checks passed
@david-yz-liu david-yz-liu deleted the setup.cfg-to-pyproject.toml branch June 24, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants