Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pytest Warnings #1067

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix Pytest Warnings #1067

merged 1 commit into from
Jul 23, 2024

Conversation

quiz3
Copy link
Contributor

@quiz3 quiz3 commented Jul 19, 2024

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Fixed all but 3 of the previous 1769 warnings raised when running pytest tests.

Screenshots of your changes (if applicable)

Before:
IMG_0252

After:
image

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@quiz3 quiz3 marked this pull request as ready for review July 19, 2024 19:57
@quiz3 quiz3 requested a review from david-yz-liu July 19, 2024 19:57
@quiz3 quiz3 marked this pull request as draft July 19, 2024 20:13
@quiz3 quiz3 marked this pull request as ready for review July 19, 2024 20:13
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10013782425

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.777%

Totals Coverage Status
Change from base Build 9984705022: 0.0%
Covered Lines: 2913
Relevant Lines: 3174

💛 - Coveralls

@@ -356,7 +356,7 @@ def visit_assignname(self, node: nodes.AssignName) -> None:
if _ignore_name(node.name, self.linter.config.ignore_names):
return

frame = node.frame(future=True)
frame = node.frame()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the same reference on line 342 of this file to the future argument of node.frame() does not cause the same deprecation warning.

@david-yz-liu david-yz-liu merged commit 2a48ce9 into pyta-uoft:master Jul 23, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants