Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated snapshot.py to align with MemoryViz 0.2.0 changes #1064

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

lana-w
Copy link
Contributor

@lana-w lana-w commented Jul 10, 2024

Proposed Changes

Updated snapshot.py and test_snapshot.py to align with changes to JSON in MemoryViz 0.2.0.

Primary changes were:

  • Replacing "name" with "type' when in reference to type of an object
  • Using the ".class" and ".frame" types to replace usage of isClass and stack-frame.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 9900783809

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.744%

Totals Coverage Status
Change from base Build 9864567042: 0.0%
Covered Lines: 2878
Relevant Lines: 3137

💛 - Coveralls

@lana-w lana-w requested a review from david-yz-liu July 10, 2024 21:49
@lana-w lana-w self-assigned this Jul 10, 2024
"isClass": True,
"name": type(val).__name__,
"type": ".class",
"name": val.__class__.__name__,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you changed the call to type here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize now that the type call works directly, so have changed it back for consistency!

"name": "func1",
"stack_frame": True,
"id": None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is showing up because you reordered this entry, but you should move it back to its original spot to ensure the diff is as small as possible

(same as in the other test cases below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@lana-w
Copy link
Contributor Author

lana-w commented Jul 12, 2024

@david-yz-liu Resolved both comments above!

@david-yz-liu david-yz-liu merged commit 49c8e3e into pyta-uoft:master Jul 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants