-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated snapshot.py to align with MemoryViz 0.2.0 changes #1064
Conversation
…hot-updates "Merged main in"
Pull Request Test Coverage Report for Build 9900783809Details
💛 - Coveralls |
python_ta/debug/snapshot.py
Outdated
"isClass": True, | ||
"name": type(val).__name__, | ||
"type": ".class", | ||
"name": val.__class__.__name__, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you changed the call to type
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize now that the type call works directly, so have changed it back for consistency!
"name": "func1", | ||
"stack_frame": True, | ||
"id": None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is showing up because you reordered this entry, but you should move it back to its original spot to ensure the diff is as small as possible
(same as in the other test cases below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@david-yz-liu Resolved both comments above! |
Proposed Changes
Updated
snapshot.py
andtest_snapshot.py
to align with changes to JSON in MemoryViz 0.2.0.Primary changes were:
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments