First step at enabling searching in index page #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laomuon
commented
Sep 7, 2024
Comment on lines
+174
to
+175
| gboolean search_equal_func_index(GtkTreeModel* model, gint column, const gchar* key, GtkTreeIter* iter, | ||
| gpointer search_data) { |
There was a problem hiding this comment.
Reimplement the search equal function so that it will also compared with collapsed entries
| @@ -125,6 +128,82 @@ static gboolean search_current_index(GtkTreeModel* model, GtkTreePath* UNUSED(pa | |||
| return FALSE; | |||
| } | |||
|
|
|||
| static bool find_substring(const char* source_str, const char* search_str) { | |||
There was a problem hiding this comment.
Find the search_str in source_str, as opposed to only match from the beginning of source_str
| @@ -1203,6 +1203,8 @@ bool sc_toggle_index(girara_session_t* session, girara_argument_t* UNUSED(argume | |||
| g_object_set(G_OBJECT(renderer), "ellipsize", PANGO_ELLIPSIZE_END, NULL); | |||
| g_object_set(G_OBJECT(gtk_tree_view_get_column(GTK_TREE_VIEW(treeview), 0)), "expand", TRUE, NULL); | |||
| gtk_tree_view_column_set_alignment(gtk_tree_view_get_column(GTK_TREE_VIEW(treeview), 1), 1.0f); | |||
| gtk_tree_view_set_search_equal_func(GTK_TREE_VIEW(treeview), search_equal_func_index, treeview, NULL); | |||
| gtk_tree_view_set_enable_search(GTK_TREE_VIEW(treeview), FALSE); | |||
There was a problem hiding this comment.
Disable interactive search by default, so that all the hotkeys (j, k, q...) are not consummed by the search function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proof of concept for enabling search in index page. It only use the native functionality of
GTK.The behavior:
C-f(the default shortcut ofGTK) to have the interactive search window appearPartly fixes #565