Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap notification text #45

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

jdujava
Copy link

@jdujava jdujava commented Jul 10, 2024

Enable wrapping of notification_text. Also add small left/right margins.

Partially fixes pwmt/zathura#624.

Copy link
Member

@sebastinas sebastinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be toogleable depending on the use of girara_notify. Not sure what the best approach is to make it generally useable.

girara/session.c Outdated Show resolved Hide resolved
Signed-off-by: Jonas Dujava <[email protected]>
@jdujava
Copy link
Author

jdujava commented Aug 2, 2024

Is there currently some usecase where the text wrapping is undesirable? Focusing mainly on zathura, either the warning/error messages are short (so it doesn't make a difference), or I would rather see the whole message (copied text, PDF information, ...).

To be honest, I am not really confident that I would come up with a nice way to toggle it (and consistently apply necessary changes to other projects). Leaving it to someone more competent would be ideal :).

@sebastinas
Copy link
Member

One approach to implement this would be to duplicate the notification area/code for a wrapped version and then check the uses of girara_notify where a wrapped version makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollable notification area
2 participants