Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding npm bootstrap5 / .json files modified #428

Merged
merged 1 commit into from
Jun 28, 2022
Merged

adding npm bootstrap5 / .json files modified #428

merged 1 commit into from
Jun 28, 2022

Conversation

stephaniequintana
Copy link
Collaborator

This PR includes Bootstrap 5 dependencies that were forgotten in #426 (rebase #423 and #417). It includes only changes to the package-lock.json and package.json files.

Screen Shot 2022-06-24 at 4 52 07 PM

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Jun 24, 2022

@stephaniequintana
Copy link
Collaborator Author

@jywarren, @cesswairimu, @TildaDares,
In creating a new branch for #423 (due to an out-of-sync previous branch), I inadvertently left out the bootstrap dependancy. Please let me know if there are any issues with including this.

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!!

@jywarren jywarren merged commit 73ecda7 into publiclab:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants