Added test for Apply button #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@publiclab/is-reviewers |
Codecov Report
@@ Coverage Diff @@
## main #1579 +/- ##
===========================================
+ Coverage 55.11% 65.41% +10.29%
===========================================
Files 117 132 +15
Lines 2344 2741 +397
Branches 360 438 +78
===========================================
+ Hits 1292 1793 +501
+ Misses 1052 948 -104
|
rishabhshuklax
requested changes
Jan 28, 2020
| //Lets change the default value | ||
| expect(Length1).toBe(2); | ||
| // Let's check the source of the image output by the default values | ||
| const src1 = await page.evaluate(() => document.querySelectorAll('.step img')[1].src); |
There was a problem hiding this comment.
Do we need to check for all of these every time?
There was a problem hiding this comment.
I think a bit of extra testing is ok for the UI tests we badly need; we can do another phase of refining and optimizing them later but it doesn't add much overhead here! But thanks for thinking of this!
|
|
jywarren
approved these changes
Jul 12, 2020
This was referenced Jul 12, 2020
jywarren
approved these changes
Jul 12, 2020
|
Thank you for these tests! Much appreciated!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns #1369 (<=== Replace
0000with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!