Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing on 3.13 beta #6720

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Start testing on 3.13 beta #6720

merged 1 commit into from
Sep 19, 2024

Conversation

nateprewitt
Copy link
Member

It looks like we're currently blocked on wheels for a few testing dependencies so this isn't mergable currently but we'll use this PR to monitor upstream support from other projects. Once those blockers are moved, we can merge this into our CI to prepare for the upcoming release candidates.

Currently it looks like flsgger and greenlet are having issues from httpbin. I think we have an open proposal/request to make flsgger optional which seems fine. greenlet currently has a proposed patch from Victor Stinner so I would assume that's resolved sooner than later.

@nateprewitt nateprewitt closed this Aug 2, 2024
@nateprewitt nateprewitt reopened this Aug 2, 2024
@nateprewitt
Copy link
Member Author

nateprewitt commented Aug 2, 2024

Looks like we're still blocked on python-greenlet/greenlet#392. Victor Stinner's patch which appears to fix the issue has been stalled for a couple months. We'll continue to keep an eye on that as we get closer to 3.13 release on October 1st, 2024.

@sethmlarson
Copy link
Member

@nateprewitt Is greenlet only needed for the gunicorn worker? Could we drop that as well in httpbin in favor of some other worker type? Or some other WSGI implementation?

@nateprewitt
Copy link
Member Author

Yeah, we definitely have options in httpbin to resolve the issue. I was going to wait until we're close to 3.13 release before we started pursuing changes there. We honestly don't even need flasgger there, it was a very late add to the project before development stopped. I would bias towards us just moving that to an optional dependency.

@graingert
Copy link
Contributor

graingert commented Aug 8, 2024

@nateprewitt greenlet is only needed as a dependency of gevent, it shouldn't be a direct dep psf/httpbin#51

It's currently blocking pytest-httpbin 3.13 support: kevin1024/pytest-httpbin#90

@sigmavirus24 sigmavirus24 merged commit 0f5ef1b into psf:main Sep 19, 2024
51 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants