Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sheared text box with filter count and use in multi/playlists lounge #29910

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Sep 18, 2024

To be used in song select redesign also, but demonstrating it in playlists/multi as that has the newer OverlayColourProvider/sheared design, and may look out of place in current song select design:

Screenshot 2024-09-17 at 8 16 24 PM

Unsure about the code. Made a separate ShearedFilterTextBox instead of incorporating it into the base as there may be cases where the filter count doesn't make sense. Like maybe ModSelectOverlay unless it makes sense to add the count there too.

@peppy
Copy link
Sponsor Member

peppy commented Sep 18, 2024

That vertical caret looks so out of place... at very least it needs more padding, at most it needs actual design thought (I assume an active state was not included in the design, so this should be added / provided cc @arflyte).

@bdach
Copy link
Collaborator

bdach commented Sep 18, 2024

Caret is one thing but I'm not sure what this alignment is supposed to be in general:

image

It's so disjointed. Nothing is aligned to anything. Why is the count text further away from the edge rather than closer to follow the shearing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants