Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): improve v5 migration guide #2749

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Sep 18, 2024

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 9:58am

Copy link

codesandbox-ci bot commented Sep 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Sep 18, 2024

Size Change: 0 B

Total Size: 12 kB

ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 64 B
./dist/esm/middleware.mjs 3.56 kB
./dist/esm/middleware/immer.mjs 210 B
./dist/esm/react.mjs 320 B
./dist/esm/react/shallow.mjs 193 B
./dist/esm/shallow.mjs 82 B
./dist/esm/traditional.mjs 411 B
./dist/esm/vanilla.mjs 403 B
./dist/esm/vanilla/shallow.mjs 550 B
./dist/index.js 244 B
./dist/middleware.js 3.56 kB
./dist/middleware/immer.js 229 B
./dist/react.js 336 B
./dist/react/shallow.js 208 B
./dist/shallow.js 189 B
./dist/traditional.js 423 B
./dist/vanilla.js 416 B
./dist/vanilla/shallow.js 562 B

compressed-size-action

docs/migrations/migrating-to-v5.md Outdated Show resolved Hide resolved
)
```

Here's another example that may cause infinite loops.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand why there is "another example," but the comment says that it's v4. Didn't you mean to say "Here's a similar example in v4 that may cause infinite loops?"

Copy link
Member Author

@dai-shi dai-shi Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean there are several cases that can cause infinite loops.
I want to show typical two examples that are actually reported by users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants