pkp/pkp-lib#10319 Implement ORCID brand guidelines #10346
Conversation
taslangraham
force-pushed
the
i10319-main
branch
4 times, most recently
from
be5444a
to
c0fc1a3
Compare
| "https://info.orcid.org/wp-content/uploads/2020/12/ORCIDiD_icon16x16.png\" " | ||
| "width='16' height='16' alt=\"ORCID iD icon\" style=\"display: block; margin: " | ||
| "0 .5em 0 0; padding: 0; float: left;\"/>Register or Connect your ORCID " | ||
| "iD</a><br/>\n" | ||
| "<br>\n" | ||
| "<br>\n" | ||
| "If the button above does not work, please use this link to register or connect your ORCID iD: <a href=\"{$authorOrcidUrl}\">{$authorOrcidUrl}.</a>\n" |
There was a problem hiding this comment.
@Devika008 this is for the ORCID invitation where there's a button and the URL in plain text. Just wanted to check with you on the wording here. I know some email services will completely remove the button so not sure what best practices is here. Thanks!
There was a problem hiding this comment.
Even if email services remove buttons, we can still highlight the link in three simple ways using clear text links.
- Use Descriptive Text Links: Click here to review your submission: www.example.com/review
- Highlight the Links: Access your dashboard here: www.example.com/dashboard
- To complete your submission, follow this link: www.example.com/complete
I think option 2 is something which is straight and to the point
Click here to verify your account with ORCID: {link}
templates/user/identityForm.tpl
Outdated
| {include file="form/orcidProfile.tpl"} | ||
| {if $orcid && $orcidAuthenticated} | ||
| {include file="linkAction/buttonConfirmationLinkAction.tpl" titleIcon="modal_delete" buttonSelector="#deleteOrcidButton" dialogText="orcid.field.deleteOrcidModal.message"} | ||
| {* {fbvElement type="button" label="common.delete" class="pkp_button pkp_button_offset"}*} |
There was a problem hiding this comment.
Can this commented-out fbvElement be removed completely?
|
|
||
| {if $verifySuccess} | ||
| <script type="text/javascript"> | ||
| setTimeout(function() { |
There was a problem hiding this comment.
Should be spaces instead of tabs here and the next two lines.
| @@ -36,6 +36,9 @@ | |||
| {elseif $submissionNotPublished} | |||
| {translate key="orcid.verify.sendSubmissionToOrcid.notpublished"} | |||
| {/if} | |||
| <span class='orcid-redirect'> | |||
| {translate key="orcid.verify.success.redirect" contextName=$contextName} | |||
There was a problem hiding this comment.
Was this redirect part of the recommendations per ORCID? At first I thought something was wrong because I didn't have time to read the message saying it would automatically be redirected. If the redirect is desired, I think the notification about it needs to be more front-and-centre and maybe a little longer given the amount of text to process. Curious what you think, though.
There was a problem hiding this comment.
It's part of the recommendations in the ORCID docs. You can see it under the "Provide feedback that their record has been connected" section.
We could make the redirect happen after about 10 seconds(it currently happens after 5) and make the text bold.
There was a problem hiding this comment.
Perfect, that sounds good to me. Maybe try having the redirect notice on a new line as well to see how that looks?
| @@ -51,16 +51,24 @@ | |||
| {/fbvFormSection} | |||
|
|
|||
| {if $orcidEnabled} | |||
|
|
|||
| <div class="orcid_container"> | |||
There was a problem hiding this comment.
I'm not sure if this broke here specifically, but the code in AuthorizeUserData that's supposed to place the ORCID value onto the page and remove the button isn't working anymore.
| @@ -518,15 +518,21 @@ msgstr "" | |||
| "submission to your ORCID profile on publication.<br>\n" | |||
| "Visit the link to the official ORCID website, login with your profile and " | |||
| "authorize the access by following the instructions.<br>\n" | |||
| "<a href=\"{$authorOrcidUrl}\"><img id=\"orcid-id-logo\" src=\"" | |||
| "<br>\n" | |||
| "<a href=\"{$authorOrcidUrl}\" style=\"display: inline-flex; align-items: center; background-color: white; text-align: center; padding: 10px 20px; text-decoration: none; border-radius: 5px; border: 2px solid #d7d4d4;\">" | |||
There was a problem hiding this comment.
This looks okay to me, but just want to run it by @Devika008 since (to my knowledge) this is the first "button" we've included in emails. Just want to make sure it's following best practices for compatibility and accessibility, especially given the varying degrees of CSS support in email clients.
There was a problem hiding this comment.
I've done a bit more looking into things and this should be okay.
taslangraham
force-pushed
the
i10319-main
branch
2 times, most recently
from
f574d78
to
733b488
Compare
|
@ewhanson Thanks for the review. I've made the suggested changes. Awaiting @Devika008's input on your questions |
taslangraham
force-pushed
the
i10319-main
branch
from
733b488
to
a965aaf
Compare
For #10319