Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: better looking icons for connect with us #1680

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AnishKhadtare
Copy link

@AnishKhadtare AnishKhadtare commented Sep 18, 2024

What does this PR do?

This PR changes the social media logos of YouTube, Twitter, GitHub, LinkedIn to new react icons with colors filled in it.
The NewTwitterLogo component is also updated to accept the prop for customizing the fill color of the SVG. This allows the Twitter logo to be styled with a specific color and also maintain the hover effect on it.

Fixes #1673

image

output.Video.mp4

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • [ Checked whether the new react logos are displayed, and the appropriate color is used] Test A
  • [ Checked whether the hover effect is also displayed] Test B

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Sep 18, 2024

@AnishKhadtare is attempting to deploy a commit to the Piyush Garg's projects Team on Vercel.

A member of the Team first needs to authorize it.

@AnishKhadtare AnishKhadtare changed the title Fix/1673 better looking icons for connect with us fix/1673 better looking icons for connect with us Sep 18, 2024
@AnishKhadtare AnishKhadtare changed the title fix/1673 better looking icons for connect with us style: better looking icons for connect with us Sep 18, 2024
@jeraldin2003
Copy link

Admins please merge this request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better looking icons for connect with us
2 participants