Build with CLAP functional #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alias clap-pillar = " <absolute pth to VM> <absolute path to image> clap"
…t, in several methods and it's working!
…each builder (peer programming with Guillermo)
build command + builders subcommands, in PRTarget
guillep
requested changes
Mar 12, 2020
| @@ -175,7 +175,8 @@ ConfigurationForPillar >> attribution: aValue [ | |||
| { #category : #accessing } | |||
| ConfigurationForPillar >> baseDirectory [ | |||
| "generated code" | |||
| ^ self propertyAt: #baseDirectory ifAbsent: [(FileSystem workingDirectory / '.')] | |||
| "^ self propertyAt: #baseDirectory ifAbsent: [(FileSystem workingDirectory) / '.']" | |||
There was a problem hiding this comment.
We should remove commented code :)
|
|
||
| { #category : #'command line' } | ||
| ClapPillarBuildCommand class >> commandSpecification [ | ||
| <commandline> |
There was a problem hiding this comment.
Shouldn't this be correctly indented?
LaurineDargaud
changed the title
|
I do not really understand the points :) S |
|
@LaurineDargaud can you confirm that this PR is obsolete and #443 is the good one I should look at? Can I close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required: clap-st project by cdlm
Build as a CLAP commandline + subcommand in PRTarget created for each builder
By default: mainRoot strategy
Order to apply flags: check list then all then main
Used flags : -a for all, -m for mainRoot (maybe useless...) + help
Seen with Damien: delete methods which create strategy (buildAll, buildMainRoot...)