Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 new endpoints for WAF( Web Application Firewall) #4

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

nl-ria
Copy link

@nl-ria nl-ria commented Feb 5, 2018

Added 2 new endpoints from the WAF API.

  1. Get WAFs: Lists all the WAFs associated with the service, given the service ID and the version.
  2. Update WAF Rule Status by Tags: updates the status of the WAF rule(s) by Tags(s).

Added tests and checks.

@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          24     38   +14     
=====================================
+ Hits           24     38   +14
Impacted Files Coverage Δ
src/config.js 100% <ø> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 563a0b8...9edbd58. Read the comment docs.

@philippschulte
Copy link
Owner

Hi Nikita,

Sorry for the delay in getting back to you! Thanks for contributing to the project! I think we also need to update the README file. I haven't played with the WAF endpoints yet. Therefore, please give me some time to test your changes. I'll get back to you as soon as I have an update.

Thanks,
Philipp

@philippschulte philippschulte self-assigned this Feb 21, 2018
nl-ria and others added 9 commits February 27, 2018 09:47
Method to get rules by status
* Trying to add pagination-2.0

* Trying to add pagination-2.0

* Code cleanup

* Added comment for the return
* Trying to add pagination-2.0

* Trying to add pagination-2.0

* Code cleanup

* Added comment for the return

* Added comment for the return
Activate WAF Config method with tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants