Fix: #1547: whenWillCloseDo: block is evaluated twice when closing a window

[Ducasse]

We decided to remove the closeDiscardingChanges from Spec

[Ducasse]

This is a potential backport to P12.

[estebanlm]

please do not merge this, I let a comment in the reported issue.

[MarcusDenker]

What is important, too: please add a better name tan "Fix: #1547" (this looks very bad in the weekly email, too)

[Ducasse]

Right now the code of the book breaks.

[estebanlm]

Right now the code of the book breaks.

can you point me to the example that breaks ?

[Ducasse]

@koendehondt Do you remember this is in the window chapter?

[koendehondt]

Right now the code of the book breaks.

can you point me to the example that breaks ?

The example in the description of #1547 exposes the bug.

The code in the book is in section 9.3 "Preventing window close". The corresponding code is in class WindowExamplePresenter2 in the code repo. The class comment links to #1547 to indicate that the example does not work.

[estebanlm]

This is fixed upstream (I applied same thing)