Mutalk handles parametrized tests correctly #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalumboN
approved these changes
Mar 8, 2024
Comment on lines
47
to
50
| MTTestCaseReference >> method [ | ||
| ^ class >> selector | ||
|
|
||
| ^ testCase class >> testCase selector | ||
| ] |
There was a problem hiding this comment.
Maybe would be nice to have in the test case, and do testCase method or testCase methodTest or similar.
There was a problem hiding this comment.
I agree but it means changing the TestCase class, which is a different thing.
For now I guess this solution is fine
There was a problem hiding this comment.
I like the idea, maybe it's worth to do a PR to Pharo? @DurieuxPol ?
There was a problem hiding this comment.
Yes we can do that
|
Thanks @DurieuxPol and @PalumboN for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
Now
MTAnalysisretrieves correctly all tests cases from parametrized tests.I also refactored a bit
MTTestCaseReferenceso that it now has the test case as instance variable rather than the class and the selector.