Subclass replacement operator #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
reviewed
Feb 7, 2024
| ifFalse: [ | ||
| self | ||
| timesToApplyIn: aCompiledMethod | ||
| with: aParseTree ]. |
There was a problem hiding this comment.
Oh we are going to simplify this in our next pair programming session! ;)
| shouldReplace := referencedClass isClass and: [ | ||
| referencedClass subclasses notEmpty ]. | ||
| shouldReplace ifTrue: [ classesToReplace add: referencedClass ]. | ||
| shouldReplace ] ] ] |
There was a problem hiding this comment.
I want that we discuss how to fix this. I know you just followed how others were done, but I don't like blocks used like this!
|
It even seems like the CI is ok now |
Oh Nice! |
guillep
reviewed
Feb 7, 2024
| @@ -19,12 +19,14 @@ MTMethodMutationTest >> testAccessing [ | |||
| operator := MTReplacePlusWithMinusMutantOperator new. | |||
| modifiedSource := operator | |||
| modifiedSourceFor: compiledMethod | |||
| number: 1. | |||
| number: 1 | |||
| newExpression: operator newExpression. | |||
There was a problem hiding this comment.
Maybe we could have a method
MTOperator >> modifiedSourceFor: aMethod number: aNumber
self modifiedSourceFor: aMethod number: aNumber newExpression: self newExpressionto avoid duplication right?
added 15 commits
February 7, 2024 16:57
added new abstract superclass for mutantOperator and BlockBasedOperator
guillep
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Thanks @DurieuxPol !
Let's discuss about that empty method later!
| ] | ||
|
|
||
| { #category : 'instance creation' } | ||
| MTSubclassReplacementOperator >> newNodeFrom: anOldNode [ |
There was a problem hiding this comment.
Why is this method empty now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new operator,
MTSubclassReplacementOperator, which replaces a class referenced by a reference for each of its subclasses, thus creating a mutant for each one.It's worth noting that only direct subclasses are considered, not all subclasses.