Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Lifeware and Gemstone #9

Conversation

VincentBlondeau
Copy link
Member

numbers used for compilation should be using the storing function instead of printing one since it will be used for a block construction

…tead of printing one since it will be used for a block construction
@Ducasse
Copy link
Contributor

Ducasse commented Dec 20, 2023

Thanks.
We should set up a CI for this repo. Just no time for it :(
Do you have a test? What is the difference between the storeString and the asString?

@VincentBlondeau
Copy link
Member Author

CI issue is handled there: #11
About the storeString and asString, Martin summarized it well there:
https://forum.world.st/printString-and-asString-tp4733777p4733963.html

But to precise it in this context:
'self storeString' evaluation should give 'self' instance again. printString is to print the object and should not used for evaluation but for display. asString is ambiguous and uses printString which seems wrong. In Lifeware, the storeString is overridden to use only a double representation to be compatible with GemStone. Adding a test case here will not be easy because the default Pharo system doesn't have this concept, as far I as recall.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ccc116) 85.62% compared to head (2382650) 85.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   85.62%   85.62%           
=======================================
  Files         214      214           
  Lines       18445    18445           
=======================================
  Hits        15794    15794           
  Misses       2651     2651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astares astares merged commit 1da6d0a into pharo-contributions:master Dec 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants