Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed metaRecursion for borderline cases #19

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

jordanmontt
Copy link
Collaborator

Changes

  • Added shared pool in class side ENABLE to enable and disable the instrumentation. This will allow to instrument the code and then to enable the instrumentation.
  • Simplified TrapMethod: Now, we don’t have the slow and fast deactivator. We have the same for all. This faciliates the handling of meta recursions. And regenerated the automatically generated prototypes methods.
  • Changed the API to separate the instrumentation with enabling the instrumentation

@jordanmontt
Copy link
Collaborator Author

Thanks @guillep for the changes!

@jordanmontt jordanmontt merged commit bb8911d into master Jul 16, 2024
0 of 6 checks passed
@jordanmontt jordanmontt deleted the fix-metarecursion branch July 16, 2024 13:52
@Ducasse
Copy link
Contributor

Ducasse commented Jul 16, 2024

I will ask some questions when I'm back :)
The diff was long and I could not spot the changes to learn from.

@jordanmontt
Copy link
Collaborator Author

The diff was long because of the tonel v3 changes. Actually, the problem was in the deactivators. We had two deactivators (fast and slow). The fast was meant for optimizing, but it was difficult to handle properly the metarecursions. So how we decided to have only one handler for all cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants