Embed selected rule in the url when sharing. #65
Conversation
WalkthroughThe changes introduce enhancements to the Changes
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- static/scripts/shareButton.ts (2 hunks)
Additional comments not posted (1)
static/scripts/shareButton.ts (1)
58-58: Good use of fallback forselectedRule.The implementation to include the
selectedRulein the shared data with a fallback to an empty string is a robust approach. This ensures that the function can handle cases where no rule is selected without causing errors.
static/scripts/shareButton.ts
Outdated
| @@ -45,6 +45,7 @@ function tryLoadFromShareLink(codeMirror) { | |||
| "textarea.editor-input-text", | |||
| )!; | |||
| inputEditor.value = decoded["input"]; | |||
| localStorage.setItem("last-selected-rule", decoded["selectedRule"]); | |||
There was a problem hiding this comment.
Add a check for selectedRule before storing.
The change to store the selectedRule in local storage is aligned with the PR's objectives. However, it's important to ensure that selectedRule is present in the decoded data before attempting to store it. This can prevent potential issues with undefined values being set in local storage.
Consider adding a check like this:
- localStorage.setItem("last-selected-rule", decoded["selectedRule"]);
+ if (decoded["selectedRule"]) {
+ localStorage.setItem("last-selected-rule", decoded["selectedRule"]);
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| localStorage.setItem("last-selected-rule", decoded["selectedRule"]); | |
| if (decoded["selectedRule"]) { | |
| localStorage.setItem("last-selected-rule", decoded["selectedRule"]); | |
| } |
There was a problem hiding this comment.
This is a reasonable suggestion 👍
There was a problem hiding this comment.
@nathanielknight Thanks for the confirmation! 😊
|
I think the coderrabbitai review makes a good suggestion: we don't want to be setting undefined values in local storage. Other than that, this looks solid 👍 |
This PR resolves this issue #61
Summary by CodeRabbit