move basic types to pest3_core #16
Conversation
|
Warning Rate limit exceeded@tomtau has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 10 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes introduce a new core module, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Pest
participant Core
User->>Pest: Use parsing functionality
Pest->>Core: Access core parsing functions
Core-->>Pest: Return parsing results
Pest-->>User: Deliver results
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- Cargo.toml (1 hunks)
- core/Cargo.toml (1 hunks)
- core/src/lib.rs (1 hunks)
- generator/Cargo.toml (1 hunks)
- generator/src/typed/module.rs (1 hunks)
- pest/Cargo.toml (1 hunks)
- pest/src/lib.rs (2 hunks)
Files skipped from review due to trivial changes (2)
- generator/Cargo.toml
- generator/src/typed/module.rs
Additional comments not posted (21)
core/Cargo.toml (2)
1-7: Metadata section looks good.The metadata section correctly uses workspace settings for version, authors, edition, description, and license.
9-11: Dependencies section looks good.The dependencies are correctly set to use workspace settings.
pest/Cargo.toml (2)
9-11: Features section looks good.The new features section correctly defines an empty default feature set and a derive feature that depends on
pest3_derive.
14-15: Dependencies section looks good.The new dependencies on
pest3_coreandpest3_deriveare correctly added, withpest3_derivemarked as optional.Cargo.toml (1)
2-2: Workspace members update looks good.The new
coremember is correctly added to the list of workspace members.pest/src/lib.rs (8)
6-8: LGTM! Re-exporting thechoicemodule.This change promotes modularity by re-exporting the
choicemodule frompest3_core.
9-11: LGTM! Re-exporting theformattermodule.This change promotes modularity by re-exporting the
formattermodule frompest3_core.
12-14: LGTM! Re-exporting thepositionmodule.This change promotes modularity by re-exporting the
positionmodule frompest3_core.
15-17: LGTM! Re-exporting thesequencemodule.This change promotes modularity by re-exporting the
sequencemodule frompest3_core.
18-20: LGTM! Re-exporting thespanmodule.This change promotes modularity by re-exporting the
spanmodule frompest3_core.
21-23: LGTM! Re-exporting thetokenmodule.This change promotes modularity by re-exporting the
tokenmodule frompest3_core.
24-26: LGTM! Re-exporting thetypedmodule.This change promotes modularity by re-exporting the
typedmodule frompest3_core.
44-45: LGTM! Conditionally re-exporting theParser.This change promotes flexibility by conditionally re-exporting the
Parserfrompest3_derivebased on thederivefeature flag.core/src/lib.rs (8)
6-6: LGTM! Declaring thechoicemodule.This change declares the
choicemodule.
7-7: LGTM! Declaring theformattermodule.This change declares the
formattermodule.
8-8: LGTM! Declaring thepositionmodule.This change declares the
positionmodule.
9-9: LGTM! Declaring thesequencemodule.This change declares the
sequencemodule.
10-10: LGTM! Declaring thespanmodule.This change declares the
spanmodule.
11-11: LGTM! Declaring thetokenmodule.This change declares the
tokenmodule.
12-12: LGTM! Declaring thetypedmodule.This change declares the
typedmodule.
31-69: LGTM! Defining theunicodemacro.This macro generates a Unicode property type with various implementations for parsing and checking characters based on the specified Unicode property.
|
@TheVeryDarkness I refactored the crates a bit, so that it can be a single crate dependency on the client side. |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
pest/src/lib.rs (1)
44-45: Issues found with the removal of theunicodemacro.The
unicodemacro is still being used in several files. Its removal frompest/src/lib.rswithout updating its usage elsewhere will break the code. Please ensure that all occurrences of theunicodemacro are either updated or removed.
- Files affected:
pest/tests/predefined_node.rscore/src/typed/unicode.rspest/src/bin/unicode.rsAnalysis chain
Verify the impact of removing the
unicodemacro.The removal of the
unicodemacro might affect existing functionality. Ensure that all usages of this macro are updated or removed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing the `unicode` macro. # Test: Search for the macro usage. Expect: No occurrences of the macro. rg --type rust $'unicode!'Length of output: 14555
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pest/src/lib.rs (2 hunks)
Additional comments not posted (8)
pest/src/lib.rs (8)
6-8: Re-export ofchoicemodule looks good.The re-export enhances modularity by consolidating the
choicemodule withinpest3_core.
9-11: Re-export offormattermodule looks good.The re-export enhances modularity by consolidating the
formattermodule withinpest3_core.
12-14: Re-export ofpositionmodule looks good.The re-export enhances modularity by consolidating the
positionmodule withinpest3_core.
15-17: Re-export ofsequencemodule looks good.The re-export enhances modularity by consolidating the
sequencemodule withinpest3_core.
18-20: Re-export ofspanmodule looks good.The re-export enhances modularity by consolidating the
spanmodule withinpest3_core.
21-23: Re-export oftokenmodule looks good.The re-export enhances modularity by consolidating the
tokenmodule withinpest3_core.
24-26: Re-export oftypedmodule looks good.The re-export enhances modularity by consolidating the
typedmodule withinpest3_core.
44-45: Conditional re-export ofParserlooks good.The conditional re-export aligns with the feature flag usage, allowing for flexible compilation configurations.
Summary by CodeRabbit
New Features
pest3library.pestproject to enhance modularity.Bug Fixes
pest3withpest3_core.Documentation
Refactor
pest3_corefunctionalities.unicode!macro to streamline Unicode property handling.