Revert PR #12 #18
Closed
Revert PR #12 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the temporary fix in PR perl-ide#12 as the temporary fix may not be needed after Test::Vars has been updated.
oalders
requested changes
Sep 16, 2024
Bump minimum version of Test::Vars to 0.017
@oalders See last commit. Does it look right? |
oalders
reviewed
Sep 16, 2024
| @@ -6,7 +6,7 @@ requires "Moo" => "0"; | |||
| requires "PPI::Document" => "0"; | |||
| requires "Path::Tiny" => "0"; | |||
| requires "Pod::Usage" => "0"; | |||
| requires "Test::Vars" => "0"; | |||
There was a problem hiding this comment.
I think this line is enough. We don't need to set the version in dist.ini and the other changes will be generated by Dist::Zilla as well. I could have been a lot clearer about that. My bad!
There was a problem hiding this comment.
No problem! I have reverted the other changes :)
|
Thank you so much @hakonhagland! I've squashed and merged at the command line via 78461f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #17 (comment)
Revert the temporary fix in PR #12 as the temporary fix may not be needed after Test::Vars has been updated.