Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Levi's first draft #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Levi's first draft #80

wants to merge 2 commits into from

Conversation

levikl
Copy link

@levikl levikl commented Jan 18, 2018

mikegee
mikegee reviewed Jan 20, 2018
View reviewed changes
Copy link
Member

@mikegee mikegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting instance methods to encapsulate the concepts. For instance, checking the input for all caps might be easier to read as too_quiet?(input). Also, @bye_counter is compared with 3 in two places. Is there another concept hiding there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegee mikegee mikegee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levikl @mikegee