Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to "Type definitions" to PURL-TYPES.rst #316

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bact
Copy link

@bact bact commented Jul 26, 2024

Currently, the text in PURL-SPECIFICATION.rst said:

[See] PURL-SPECIFICATION.rst for known type definitions.

which is self-reference and also not correct.

  • PURL-SPECIFICATION.rst is the core spec.
  • Type definitions are in PURL-TYPES.rst

Edited to use similar sentence structure as one in PURL-TYPES.rst:

See also https://github.com/package-url/purl-spec and PURL-SPECIFICATION.rst for the Package URL specification.

Proposed text to be used in PURL-SPECIFICATION.rst:

See also https://github.com/package-url/purl-spec and PURL-TYPES.rst for known type definitions.

bact added 2 commits July 27, 2024 00:53
Currently, the text said:

> (See) PURL-SPECIFICATION.rst for known type definitions.

which is not correct.

- `PURL-SPECIFICATION.rst` is the core spec.
- Type definitions are in `PURL-TYPES.rst`

Edit to use similar sentence structure as one in [PURL-TYPES.rst](https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst):
> See also https://github.com/package-url/purl-spec and PURL-SPECIFICATION.rst for the Package URL specification.
Copy link

@oej oej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to merge

@bact bact changed the title Known type definitions is in PURL-TYPES.rst Fix link to "Type definitions" to PURL-TYPES.rst Sep 6, 2024
@bact
Copy link
Author

bact commented Sep 6, 2024

@pombredanne please kindly review. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants