Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v2.0.0 #243

Closed
wants to merge 2 commits into from
Closed

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 6, 2024

🤖 New release

  • oxc_resolver: 1.11.0 -> 2.0.0
Changelog

2.0.0 - 2024-09-06

Added

  • give a specific error for matched alias not found (#238)

Fixed

  • fix .github/workflows/release-plz.yml

Other

  • set GH_TOKEN for "Bump package.json" in release-plz.yml
  • update package.json in release-plz.yml (#242)
  • apply semver_check to release-plz (#241)
  • (deps) update dependency rust to v1.81.0 (#239)
  • (deps) update crate-ci/typos action to v1.24.5
  • (deps) update crate-ci/typos action to v1.24.4
  • (deps) update crate-ci/typos action to v1.24.3
  • add esm / cjs condition_names to examples


This PR was generated with release-plz.

Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #243 will not alter performance

Comparing release-plz-2024-09-06T02-34-37Z (344df25) with main (bc70948)

Summary

✅ 3 untouched benchmarks

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.86%. Comparing base (bc70948) to head (344df25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          11       11           
  Lines        2358     2358           
=======================================
  Hits         2284     2284           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot force-pushed the release-plz-2024-09-06T02-34-37Z branch from 344df25 to ee384d3 Compare September 6, 2024 02:37
@Boshen
Copy link
Member Author

Boshen commented Sep 6, 2024

Should I add a non_exhaustive?

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_variant_added.ron

Failed in:
  variant ResolveError:MatchedAliasNotFound in /home/runner/work/oxc-resolver/oxc-resolver/src/error.rs:29
    Summary semver requires new major version: 1 major and 0 minor checks failed

@ematipico
Copy link
Collaborator

I have to admit that the changelog doesn't say anything about what are the breaking changes, or if there are any, since we're shipping a major.

Any chance we can write something about it?

@Boshen Boshen marked this pull request as draft September 6, 2024 07:24
@Boshen
Copy link
Member Author

Boshen commented Sep 6, 2024

I have to admit that the changelog doesn't say anything about what are the breaking changes, or if there are any, since we're shipping a major.

Any chance we can write something about it?

Yes absolutely, I'm in the process of learning and applying cargo-semver-checks to this repo so I can use it in oxc in a few months.

@Boshen Boshen closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants