Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add semver check #240

Closed
wants to merge 1 commit into from
Closed

ci: add semver check #240

wants to merge 1 commit into from

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 6, 2024

No description provided.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.86%. Comparing base (a7674ce) to head (b92ca0e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          11       11           
  Lines        2358     2358           
=======================================
  Hits         2284     2284           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #240 will not alter performance

Comparing cargo-semver-checks (b92ca0e) with main (a7674ce)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen marked this pull request as draft September 6, 2024 01:02
@Boshen
Copy link
Member Author

Boshen commented Sep 6, 2024

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_variant_added.ron

Failed in:
  variant ResolveError:MatchedAliasNotFound in /home/runner/work/oxc-resolver/oxc-resolver/src/error.rs:29
    Summary semver requires new major version: 1 major and 0 minor checks failed

@Boshen Boshen closed this Sep 6, 2024
@Boshen Boshen deleted the cargo-semver-checks branch September 6, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant