Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curl] Added --interface argument to improve IPv6 support #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[curl] Added --interface argument to improve IPv6 support #30

wants to merge 1 commit into from

Conversation

klukonin
Copy link
Contributor

@klukonin klukonin commented Apr 4, 2017

[curl] Added --interface argument to improve IPv6 support.

Curl need to be run with --interface option for normal work with ipv6. It does not have an effect on ipv4, but help to manage devices through ipv6.
Also this can be present as a security improvement.
May be better to add this to the official docs.

@nemesifier
Copy link
Member

@klukonin are we 100% sure this change will not affect ipv4 only users? I think the best thing to do is to discuss this on the OpenWISP forum/mailing list before merging this change. Could you open a thread there please?

Could you also change the commit message to something like [curl] Added --interface argument to support IPv6 please?

@klukonin
Copy link
Contributor Author

klukonin commented Apr 4, 2017

@klukonin klukonin changed the title IPv6 work fix [curl] Added --interface argument to improve IPv6 support Apr 4, 2017
@klukonin
Copy link
Contributor Author

klukonin commented Apr 4, 2017

@nemesisdesign
I made some tests and ipv4 devices worked as usual. So, looks like we have a good chance ))

@nemesifier
Copy link
Member

@klukonin great news. I will also perform some tests when I get back from a work trip on monday

You edited the pull request title successfully, now you should edit the commit message too, you can do this with:

git commit --amend -m '[curl] Added --interface argument to improve IPv6 support'
git push -f origin patch-2

This will update the commit sent in this pull request automatically.

@nemesifier
Copy link
Member

nemesifier commented Apr 7, 2017

I think the current patch may cause problems if someone is using a different uplink interface than what is used to calculate the mac-address of the device.

The most conservative way to introduce support for ipv6 link-local, in order to not risk breaking usage for existing installations, is to introduce a configuration option which is disabled by default and has 3 possible values:

  • '0' (disabled, this should be the default)
  • '1' (enabled and value defaults to $MAC_INTERFACE)
  • 'interface_name' (explicit interface name)

The name for this new configuration option could be simply "interface".

nemesifier added a commit that referenced this pull request Apr 11, 2017
@nemesifier
Copy link
Member

I am not sure this thing can work: I have tried to tell CURL to send an HTTP request to an ipv6 link local address but I couldn't get it working.

If you could give me an example of how to replicate the setup you are interested in supporting I will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants