use dashes in attribute values, #1074
Conversation
This updates the Invokers explainer to match the current conclusions based on WHATWG discussions.
keithamus
requested review from
lukewarlow,
gregwhitworth,
mfreed7 and
dbaron
as code owners
| Custom command values _must_ contain a `-`. They will _never_ trigger a browser | ||
| default behaviour, aside from dispatching an `CommandEvent`. This allows web | ||
| developers to create custom Invoke actions for their components. | ||
| Custom command values _must_ start with a `-`. This is a safe namespace to use, |
There was a problem hiding this comment.
Did you mean "contain a -"? I don't know of any other namespace in HTML that uses a single dash - for custom things. Custom elements must just contain a -.
| | Invokee Element | `action` hint | Behaviour | | ||
| | :-------------- | :-------------------- | :--------------------------------------------------------------------------------------------------------- | | ||
| | `<* popover>` | `'toggle-popover'` | Shows the `popover` if closed, otherwise hides. Similar to `.togglePopover()` | | ||
| | `<* popover>` | `'hide-popover'` | Hides the `popover` if open, otherwise does nothing. Similar to `.hidePopover()` | |
There was a problem hiding this comment.
Ahh, I see where the "starts with -" came from. Perhaps the custom ones should use a starting double-dash -- to match CSS? I'd just hate to mint yet another naming scheme. I'm surprised @annevk was supportive of this naming scheme. Perhaps it exists somewhere else in HTML that I'm not thinking of?
There was a problem hiding this comment.
I agree, this needs some more thought. Hopefully we'll discuss in the openui call in ~10hrs 😆.
I'll merge this in its current state, with the genuine hope that I'll be following up with a more refined way to handle custom actions.
There was a problem hiding this comment.
The only reason CSS has two hyphens is because a single hyphen clashes with vendor prefixes. I don't think I'm opposed to mandating an additional hyphen, but there's little point to it I think.
This updates the Invokers explainer to match the current conclusions based on WHATWG discussions.
See whatwg/html#10471 for minutes.
We'll hopefully discuss the heuristics for custom attributes in the next OpenUI meeting, but for now this commits the latest reality of what is being proposed.