feat: pluggable url for idv location #35494
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url = IDVerificationService.get_verify_location() | ||
| assert url == TestIdvPageUrlRequestedPipelineStep.TEST_URL | ||
|
|
||
| url = IDVerificationService.get_verify_location('course-v1:edX+DemoX+Demo_Course') |
There was a problem hiding this comment.
Suggestion: is there a reason that the urls tested are both the same here? I'm not sure if this would make a difference, but would it be better for the urls to be different. Or is the point that they should in fact be the same? Maybe I'm misunderstanding.
There was a problem hiding this comment.
I want the output the same because I'm validating the url is overridden by the filter hook in both cases.
There was a problem hiding this comment.
We should also test the case when the filter is not configured so we know it's not getting overridden.
| @@ -244,7 +245,8 @@ def get_verify_location(cls, course_id=None): | |||
| location = f'{settings.ACCOUNT_MICROFRONTEND_URL}/id-verification' | |||
| if course_id: | |||
| location += f'?course_id={quote(str(course_id))}' | |||
| return location | |||
|
|
|||
| return IDVPageURLRequested.run_filter(location) | |||
There was a problem hiding this comment.
Don't forget to add:
# .. filter_implemented_name: IDVPageURLRequested
# .. filter_type: org.openedx.learning.idv.page.url.requested.v1
So it's easier to identify later on. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is blocked from merging until openedx/openedx-filters#213 is available in edx-platform
Description
Adds an extension point when generating the url for id verification. This makes use of a new filter introduced here (openedx/openedx-filters#213) to allow plugin code to override where a user would be directed to complete the verification process.
Supporting information
This is part of the overall IDV plugability approach defined here: openedx/platform-roadmap#367
2U Internal Ticket: COSMO-429