#7224 Pull images parallel during deployment #278
Conversation
|
Looks good but how was this tested? Can you also describe the intent in few lines on the Longer term we should also have error control here - eg if pull failed we shouldnt move forward. Right now it will just hammer through, but this change doesn't really make it any worse just maintains that |
| done | ||
|
|
||
| echo "Images are getting downloaded" |
There was a problem hiding this comment.
Would this disappear in the log output of the pull(s)? Eg are they outputting earlier and parallel so this gets lost in their log output...?
If so we can drop this
There was a problem hiding this comment.
No, I could see it the logs as i have rephrased the sentence "Images download is in process" to "Images are getting downloaded" for better as per the if you check https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10938830700/job/30369325656 (line-194) and in Line- 2190 i have again put check-mark "Images are successfully downloaded" to confirm the images are downloaded and the wait has happened.
We had first cleaned the docker images from the development env servers before deploying. by using below commands.
docker stack ls
NAME SERVICES
opencrvs 34
docker stack rm opencrvs
docker system prine -af
then had triggered the github action with the code changes from https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10938830700/job/30369325656 and then repeated the cleanup process and triggered with the old code changes. https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10937970094
As per the pipeline triggered it had taken less time.