fix: validate date string before converting to LocalDate (#6880) (#6883)

* fix: validate date string before converting * docs: update CHANGELOG
opencrvs · Apr 30, 2024 · 29436e1 · 29436e1
1 parent 226d6f5
commit 29436e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## [1.3.5](https://github.com/opencrvs/opencrvs-core/compare/v1.3.4...v1.3.5)
 
+## Bug fixes
+- #### Fix download failure for incomplete (without date of death) death declarations [#6807](https://github.com/opencrvs/opencrvs-core/issues/6807)
+
 ## [1.3.4](https://github.com/opencrvs/opencrvs-core/compare/v1.3.3...v1.3.4)
 
 ## Bug fixes

diff --git a/...client/src/forms/register/mappings/event-specific-fields/death/query/deceased-mappings.ts b/...client/src/forms/register/mappings/event-specific-fields/death/query/deceased-mappings.ts
@@ -9,7 +9,10 @@
  * Copyright (C) The OpenCRVS Authors located at https://github.com/opencrvs/opencrvs-core/blob/master/AUTHORS.
  */
 import { IFormField, IFormData } from '@client/forms'
-import { formatPlainDate } from '@client/utils/date-formatting'
+import {
+  formatPlainDate,
+  isValidPlainDate
+} from '@client/utils/date-formatting'
 
 export const deceasedDateToFieldTransformation =
   (alternativeSectionId?: string) =>
@@ -46,8 +49,7 @@ export const deceasedDateFormatTransformation =
     }
     const queryValue = queryData[fromSectionId].deceased.deathDate
 
-    const date = new Date(queryValue)
-    if (!Number.isNaN(date.getTime())) {
+    if (isValidPlainDate(queryValue)) {
       const prevLocale = window.__localeId__
       window.__localeId__ = locale