-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add content_filter and function_call to finish_reason #88
Conversation
r? @athyuttamre |
openapi.yaml
Outdated
`length` if the maximum number of tokens specified in the request was reached, | ||
`content_filter` if content was omitted due to a flag from our content filters, | ||
or `function_call` if the model decided to call a function. | ||
|
||
enum: ["stop", "length", "content_filter", "function_call"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite right.
v1/completions
only supports stop
, length
, and content_filter
. v1/chat/completions
supports all 4.
I think this line should be only the first three, and this line should have all 4 instead.
Could you update? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch @athyuttamre ! Got turned around. Re-review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch @athyuttamre ! Got turned around. Re-review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch @athyuttamre ! Got turned around. Re-review?
Missed this in openai#88, I think
Would address openai/openai-node#320
I have not verified whether this or https://platform.openai.com/docs/guides/gpt/chat-completions-api is more accurate on this subject.